permission: support URL and Uint8Array as has()/drop() reference by nhjbest22 · Pull Request #65492 · nodejs/node

nhjbest22 · 2026-08-22T18:10:31Z

process.permission.has()/drop() only accepted a string or Buffer for
the reference argument. This adds support for a WHATWG URL, resolved
via fileURLToPath() for fs.* scopes since those are the only scopes
that actually use the reference value, and a plain Uint8Array.

Also switches permission.cc from Utf8Value to BufferValue when reading
a Buffer/TypedArray reference, since Utf8Value forces a UTF-8 string
conversion that can silently corrupt a path that isn't valid UTF-8.

nodejs-github-bot · 2026-08-22T18:10:36Z

Review requested:

@nodejs/security-wg

codecov · 2026-08-23T08:56:51Z

Codecov Report

❌ Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (cf30b2e) to head (42241f8).
⚠️ Report is 241 commits behind head on main.

Files with missing lines	Patch %	Lines
src/permission/permission.cc	72.72%	0 Missing and 3 partials ⚠️
lib/internal/process/permission.js	96.87%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65492      +/-   ##
==========================================
+ Coverage   90.11%   90.14%   +0.03%     
==========================================
  Files         752      751       -1     
  Lines      251861   252647     +786     
  Branches    47365    47549     +184     
==========================================
+ Hits       226955   227745     +790     
+ Misses      16238    16192      -46     
- Partials     8668     8710      +42

Files with missing lines	Coverage Δ
lib/internal/process/permission.js	`92.39% <96.87%> (+10.68%)`	⬆️
src/permission/permission.cc	`75.98% <72.72%> (+0.76%)`	⬆️

... and 108 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

normalizeReference() adds URL and Uint8Array support to has()/drop(); the existing string/Buffer behavior is unchanged. BufferValue replaces Utf8Value so a Buffer/TypedArray reference is copied as raw bytes instead of a lossy UTF-8 conversion. Signed-off-by: seungmin Nam <nhjbest22@g.skku.edu>

nhjbest22 · 2026-08-27T11:53:07Z

@MikeMcC399

Thank you so much for constantly keeping an eye on my PR and explaining the CI status! I'm truly amazed by all the care and effort you've put into this.

Based on your explanation, it sounds like we might see a green CI soon! I'll sit tight and wait a bit longer.

MikeMcC399 · 2026-08-27T13:27:38Z

@nhjbest22

Thank you so much for constantly keeping an eye on my PR and explaining the CI status! I'm truly amazed by all the care and effort you've put into this.

Based on your explanation, it sounds like we might see a green CI soon! I'll sit tight and wait a bit longer.

I didn't expect to be spending so much effort surrounding your PR, however it has got caught up in several generic issues, so that's why I'm continuing to follow it and get it resolved together with others on the team.

So far none of the issues seem to come from changes you've proposed in this PR, so I am hopeful to see a green CI soon! Thanks for your patience!

nodejs-github-bot · 2026-08-28T15:26:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76633/

MikeMcC399 · 2026-08-28T16:13:19Z

Jenkins is now green after many attempts 🎉. The issues it found had nothing to do with the contents of this PR and these are hidden now as resolved / outdated in the history.

Marking as author ready PRs with CI started, the required approvals, and no outstanding review comments. and handing back to the subject matter experts who approved the PR.

nhjbest22 · 2026-08-31T14:22:18Z

@MikeMcC399

Thank you so much for all your hard work and dedication to getting the CI to pass. The effort you put into this means a lot to an early contributor like me.

I look forward to continuing to contribute and working together for the Node.js community.

Thanks again!

RafaelGSS · 2026-08-31T14:50:36Z

Thanks for the support @MikeMcC399

nodejs-github-bot · 2026-08-31T14:59:50Z

Landed in c4336d9

MikeMcC399 · 2026-08-31T15:10:24Z

@nhjbest22

I'm happy to see that your PR has successfully landed! If you continue contributing, I do hope you have a better experience next time. In any case, now that you are a recognized Contributor you will find that the GitHub Actions CI runs automatically, instead of requiring an individual approval for every change. The Jenkins CI does however always need a Collaborator to first review a PR and then start the Jenkins CI.

There were a lot of different problems that came to together during the same period, including GitHub's own issues. I have to thank also @sxa and others from the team for their assistance in the background!

MikeMcC399 · 2026-08-31T15:29:24Z

Timing has not been kind to this PR 🙁 !

2ec0f9a which landed at 13:07 UTC has broken tests in the main branch.

The tests after merging this PR c4336d9 at 14:59 UTC that have failed.
There is however nothing to be done for this PR, so this is just FYI in case you are watching the https://github.com/nodejs/node/commits/main/ branch commits and CI results.

A PR #65683 is already queued to fix the tests.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Aug 22, 2026

nhjbest22 force-pushed the permission-reference-types branch from 6d518fc to 72717a5 Compare August 23, 2026 12:59

nhjbest22 force-pushed the permission-reference-types branch from 72717a5 to 42241f8 Compare August 23, 2026 13:09

RafaelGSS approved these changes Aug 24, 2026

View reviewed changes

RafaelGSS added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. permission Issues and PRs related to the Permission Model. labels Aug 24, 2026

github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 24, 2026